MIDIClient.disposeClient does not reset initialized class variable

[sensestage]

As the subject says.
When you dispose a client, the initialized class var is not set to false, and hence a re-init is not actually creating a new client.

[scztt]

Fix is to set initialized = false and clear the various classvar's?

[sensestage]

*disposeClient {
        _DisposeMIDIClient
        ^this.primitiveFailed
    }

To:

*disposeClient {
   initialized = false;
   prDisposeClient;
}

*prDisposeClient {
        _DisposeMIDIClient
        ^this.primitiveFailed
    }

But right now I am unsure if it would be wise to just dispose of the sources and destinations, I am not sure whether all that stuff gets freed properly in the primitive code.
A careful check should be made in all three primitive implementations (CoreMIDI, AlsaMIDI, and PortMIDI).

[adcxyz]

also, maybe safer to first do prDisposeClient, then set var to false, so you know the primitive worked.

 *disposeClient {
     this.prDisposeClient;
}
*prDisposeClient {
    _DisposeMIDIClient
    ^this.primitiveFailed
}

[sensestage]

This is also fixed in #1571

[vivid-synth]

Can this be closed?