Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolated bug, possibly non-reproducible: Pitch.kr stopped working, until server reboot #2586

Closed
esluyter opened this issue Dec 24, 2016 · 10 comments
Assignees
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: server plugins waiting for testing

Comments

@esluyter
Copy link

esluyter commented Dec 24, 2016

I just hit a weird bug where suddenly my code stopped working, and I traced it to a Pitch ugen. I'm still on 3.8.0-beta1 so if this resulted from something that has been fixed already, apologies. I'm running it on Mac OS X 10.11 (15A284)

Before I rebooted the server, executing e.g. this line
{ Pitch.kr(SinOsc.ar(550)).poll; }.play
would result in a series of

UGen Array [0]: 440
UGen Array [1]: 0
...

After reboot, it behaved normally:

UGen Array [0]: 440
UGen Array [1]: 0
UGen Array [0]: 548.845
UGen Array [1]: 1
UGen Array [0]: 548.846
UGen Array [1]: 1
...
@nhthn nhthn added bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: server plugins labels Dec 24, 2016
@nhthn
Copy link
Contributor

nhthn commented Dec 24, 2016

Very odd, I've never seen a bug like this. I don't see anything special in the Pitch source code that would make this happen.

The calc function appears to be calling, but it's acting as if you're just feeding silence into Pitch.

@esluyter
Copy link
Author

esluyter commented Dec 24, 2016

Just to note, other ugens behaved, sounded, and polled normally, so it wasn't like the server just stopped processing audio or anything like that.

Also to note, in case this has anything to do with it, I was working in a ProxySpace when this began, and this was the offending code:
~freq = { var in = ~sig.ar; Pitch.kr(in[0])[0] };

Then, I was able to reduce the issue to the line I posted above.

If it happens again, are there more tests I should run before rebooting the server?

@nhthn
Copy link
Contributor

nhthn commented Dec 24, 2016

I found something suspicious in the code. The median filter size is incorrectly set from the input audio instead of the median argument. I don't see any possible causal connections with this issue, however.

@nhthn nhthn self-assigned this Jan 15, 2017
@telephon
Copy link
Member

can you still reproduce it?

@esluyter
Copy link
Author

esluyter commented May 30, 2017 via email

@mossheim
Copy link
Contributor

Thanks for the update, @esluyter. Feel free to reopen if you find a way to reproduce!

@vivid-synth
Copy link
Member

@snappizz you note that

The median filter size is incorrectly set from the input audio instead of the median argument. 

Should we make a separate ticket for this?

@nhthn
Copy link
Contributor

nhthn commented May 31, 2017

yes please

@nhthn
Copy link
Contributor

nhthn commented Jan 3, 2018

more evidence that something is wrong with Pitch: http://new-supercollider-mailing-lists-forums-use-these.2681727.n2.nabble.com/Pitch-hasFreq-broken-from-sc3-8-td7637215.html

sounds like uninitialized memory to me.

@nhthn nhthn reopened this Jan 3, 2018
@mossheim
Copy link
Contributor

Not enough info here and nabble link is broken, please reopen if there is more to act on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: server plugins waiting for testing
Projects
None yet
Development

No branches or pull requests

5 participants