Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCDoc is not print-friendly #3395

Closed
prko opened this issue Jan 7, 2018 · 5 comments
Closed

SCDoc is not print-friendly #3395

prko opened this issue Jan 7, 2018 · 5 comments
Assignees
@nhthn
Labels
comp: SCDoc scdoc syntax, parser, and renderer. for changes to schelp files, use "comp: help"
Milestone
3.10

Comments

@prko
Copy link
Contributor

prko commented Jan 7, 2018 •
edited

Bug description:
Only the first pages of the HTML files produced by SC Help document system are printed in web browsers. Tested in Chrome, Safari and Edge under High Sierra and Windows 10.

Steps to reproduce:

  1. Install 3.9 rc2 or rc1
  2. Select '04. Functions and Other Functionality' under "Tutorials > Getting-Started"
  3. evaluate the following code in SC:
    (Platform.userAppSupportDir+/+"Help/Tutorials/Getting-Started/04-Functions-and-Other-Functionality.html").openOS
  4. Print

Actual result:
Only the first page is recognised in the print menu,

Expected result:
If an HTML exceeds one page when printing, the whole pages must be identified.
When doing this using 3.8 version, 3.8 works without problems.
It is apparently a bug of 3.9.

Please try the following page using web browsers.
http://doc.sccode.org/Tutorials/Getting-Started/04-Functions-and-Other-Functionality.html
In this case, all pages are recognised and printed.
@prko prko changed the title HTML processed by the Help Document System Bug HTML processed by the Help Document System Jan 7, 2018
@nhthn nhthn added this to the 3.9.1 milestone Jan 7, 2018
@nhthn nhthn self-assigned this Jan 7, 2018
@nhthn nhthn added the comp: SCDoc scdoc syntax, parser, and renderer. for changes to schelp files, use "comp: help" label Jan 7, 2018
@nhthn
Copy link
Contributor

nhthn commented Jan 7, 2018

i don't advise printing out the SC docs for the sake of trees, but this should be easy to fix.

@patrickdupuis patrickdupuis mentioned this issue Jan 8, 2018
Closed
@nhthn nhthn changed the title HTML processed by the Help Document System SCDoc is not print-friendly Jan 14, 2018
@nhthn nhthn modified the milestones: 3.9.1, 3.9.2 Jan 27, 2018
@nhthn nhthn modified the milestones: 3.9.2, 3.9.3 Mar 3, 2018
@nhthn nhthn modified the milestones: 3.9.3, 3.10 Apr 9, 2018
@nhthn nhthn added this to To Do in 3.10 Jun 25, 2018
nhthn pushed a commit to nhthn/supercollider that referenced this issue Jun 25, 2018
scdoc: restore fixed-position menu bar
d4d674b 
This commit restores the floating menu bar in SCDoc.

Fixes supercollider#3395.
@nhthn nhthn mentioned this issue Jun 29, 2018
Merged
@nhthn nhthn moved this from To Do to Doing in 3.10 Jun 29, 2018
@prko
Copy link
Contributor Author

prko commented Jul 4, 2018 •
edited

Hi,

I appreciate you for fixing this!

I have further questions about HTML.
In 3.8, the font size of an HTML automatically resized when printing the HTML if even a line inside code:: :: is too long. I don't remember what the maximal number of characters per line was.

Today, I have recognised that the HTML produced by SC 3.9 is printed out without resizing its font size even if there is a long line inside of code:: ::

Will the behaviour of 3.9 be maintained in the SC 3.10 release?
I think the behaviour of 3.9 is better than 3.8...

Thanks

@nhthn
Copy link
Contributor

nhthn commented Jul 4, 2018

please see #3831 -- it addresses this and several other SCDoc things that i messed up in 3.9.

nhthn pushed a commit to nhthn/supercollider that referenced this issue Jul 8, 2018
SCDoc: redesign menubar and TOC
fb6c79b 
This commit:

- Restores the floating menu bar in SCDoc.
- Fixes print-friendliness (supercollider#3395)
- Redesigns TOC to fix an issue with internal links (supercollider#3831)
- Unifies appearance of TOC and index submenu
- Refactors a lot of code to use jQuery
@nhthn
Copy link
Contributor

nhthn commented Jul 9, 2018

fixed!

@nhthn nhthn closed this as completed Jul 9, 2018
@nhthn nhthn moved this from Doing to Done in 3.10 Jul 9, 2018
@nhthn nhthn removed this from Done in 3.10 Jul 9, 2018
@prko
Copy link
Contributor Author

prko commented Jul 9, 2018

Thank you very much!

@prko prko mentioned this issue Jul 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhthn nhthn

Labels
comp: SCDoc scdoc syntax, parser, and renderer. for changes to schelp files, use "comp: help"
Projects
None yet
Milestone
3.10
Development

No branches or pull requests
2 participants
@prko @nhthn