Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Install quark dependencies with refspecs #1427

Merged
merged 7 commits into from Apr 24, 2015

Conversation

crucialfelix
Copy link
Member

Installs dependencies (including their dependencies) instead of just checking them out and linking them.

Fixes #1377

Parses refspecs in dependencies as advertised.
Also catches named quarks that are not found, posts the ERROR and returns nil.

Quark.parseDependency("Bjorklund");
Quark.parseDependency("DoesntExist");

Quark.parseDependency("crucial-library@tags/4.1.4");
Quark.parseDependency("crucial-library@tags/bad-tag");

Quark.parseDependency("DoesntExist@tags/4.1.4");

Quark.parseDependency("UnitTesting" -> 1.0)
Quark.parseDependency("DoesntExist" -> 1.0)

Quark.parseDependency(["UnitTesting", 1.0, "svn://sourceforge.net/etc/usw"])
Quark.parseDependency(["DoesntExist", 1.0, "svn://sourceforge.net/etc/usw"])


Quark.parseDependency("https://example.com/_404_.git");

Quark.parseDependency("https://github.com/crucialfelix/Mx.git");

Quark.parseQuarkName("https://github.com/crucialfelix/Mx.git")

@scztt scztt added this to the 3.7 milestone Apr 19, 2015
@scztt
Copy link
Contributor

scztt commented Apr 19, 2015

I mentioned this to you in an email, but this is the beginning of the test quite I was using to test quark download / installation / dependencies:
https://gist.github.com/scztt/dda6df4046a5311f48f6
It should work as-is with your pr? I haven't tried it yet, I will tomorrow if I have time.

@crucialfelix
Copy link
Member Author

to test this PR we just need to run the parseDependency checks I showed above.

monkey testing it against the whole quarks is also a good idea, but I think we can do that later.

@scztt
Copy link
Contributor

scztt commented Apr 24, 2015

@crucialfelix - spent some time testing this, seems to be working fine. Merging so we can get alpha1 out.

scztt added a commit that referenced this pull request Apr 24, 2015
Fix: Install quark dependencies with refspecs
@scztt scztt merged commit 0f6fb95 into supercollider:master Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants