Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ndef gui paramview backwards compatibility #2418

Merged
merged 1 commit into from Nov 5, 2016
Merged

ndef gui paramview backwards compatibility #2418

merged 1 commit into from Nov 5, 2016

Conversation

vividsnow
Copy link
Contributor

address #2158

jamshark70
jamshark70 reviewed Oct 22, 2016
View reviewed changes
Copy link
Contributor

@jamshark70 jamshark70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be, e.g., spec = argSpec !? { argSpec.asSpec }, shouldn't they? Not sure exactly what you mean, but it would make sense to short-circuit the branch, I guess.

@vividsnow
Copy link
Contributor Author

@jamshark70 thanks! fixed and squashed

this patch is about restoring NdefGui behavior for 2-element array arg without specs. (as in v3.7 - https://github.com/supercollider/supercollider/blob/3.7/SCClassLibrary/JITLib/GUI/EnvirGui.sc#L407)

@nhthn nhthn added the comp: class library SC class library label Oct 22, 2016
@crucialfelix crucialfelix modified the milestone: 3.9 Nov 4, 2016
@telephon telephon merged commit 7429fd3 into supercollider:master Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamshark70 jamshark70 jamshark70 left review comments

Assignees
No one assigned
Labels
comp: class library SC class library
Projects
None yet
Milestone
3.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vividsnow @jamshark70 @crucialfelix @nhthn @telephon