Maybe overrides more parent methods #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Maybe object lazily constructs an operation as an object instead of performing it immediately. Its implementation remains incomplete necessarily, in the current form. This commit adds a few common collection methods and fixes the example in the helpfile.
telephon
changed the title
nhthn
reviewed
Oct 28, 2016
| ^this.composeNAryOp(\myMethod, args) | ||
| } | ||
| } | ||
| :: |
There was a problem hiding this comment.
IMO extensions to built-in classes are a bad habit. I'm not necessarily saying that you should remove this example, but maybe warn of the possible dangers.
There was a problem hiding this comment.
Extensions for existing classes are not bad – this was the point about adding class extensions in the first place, I think. What you mean, I suppose, is that here we make the subclass override methods of its superclass?
|
I think this is fine. Opinions? |
nhthn
approved these changes
Jan 15, 2017
|
ping |
|
honk honk, anyone else want to look at this? |
mossheim
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2436