scsynth: implement /version command #2546
Conversation
nhthn
force-pushed
the
topic/scsynth-version
branch
from
c72df9b
to
060042a
Compare
|
I'm not aware of how to contribute to someone else's pull request, but I'd be happy to work on the supernova equivalent. I think we shouldn't add features to one synth without supporting them on the other. |
| packet.addi(SC_VersionMinor); | ||
| packet.addtag('s'); | ||
| packet.adds(SC_VersionPatch); | ||
|
|
There was a problem hiding this comment.
I'd love to add SC_CommitHash too!
There was a problem hiding this comment.
Sure. What about SC_Branch?
There was a problem hiding this comment.
SC_CommitHash is enough to tell us exactly what code we're running (unless the user made mods of course 😄 ). Then again, if this would be useful to someone there's no real reason not to add it
|
@snappizz did you want to add SC_Branch? Else, any objections, or are we good to merge? (I should add, looks good to me) |
|
May I suggest that this be symmetric with |
|
@Sciss yes, they both get their info from the same header file, |
|
Nice! |
|
Ace - thanks so much :-) |
This fixes #2544 for scsynth, but not for supernova.