Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: fix broken gui helpfiles #2653

Merged
merged 6 commits into from Jan 31, 2017

Conversation

telephon
Copy link
Member

This fixes #560.

@mossheim mossheim changed the title examples: fix broken gui helpfiles This fixes #560. examples: fix broken gui helpfiles Jan 16, 2017
@mossheim
Copy link
Contributor

Thanks! Will test later today.

@mossheim
Copy link
Contributor

mossheim commented Jan 17, 2017

Okay first of all, this is just super fun. I forgot how easy it is to get excited about GUI tricks!

Second of all, I'm not sure what the examples in strike.scd are supposed to be doing. At the very least the "Tetris" example does not seem to be acting like a normal tetris game, and I'm not getting any sound out of it.

Third, would you consider making the examples in x-y-plot.scd play with sound? That was something I immediately did myself out of curiosity by adding .play before .scope. I get that it's a GUI example so not a big deal.

@nhthn nhthn added the comp: help schelp documentation label Jan 17, 2017
@telephon
Copy link
Member Author

– I've simplified the sound example so you have to run only one extra bit of code.
– the x-y-plots make some sound now.

@telephon
Copy link
Member Author

Second of all, I'm not sure what the examples in strike.scd are supposed to be doing. At the very least the "Tetris" example does not seem to be acting like a normal tetris game

This is poetic, it is a portrait of tetris. Sorry that your expectations were disappointed! :)


};
);
);
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a newline here!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @telephon :)

@mossheim
Copy link
Contributor

This is poetic, it is a portrait of tetris. Sorry that your expectations were disappointed! :)

Hmm, could you describe what it is supposed be doing? What I see when I run it is a single squiggle like from the first example descend about 2/3 of the way down the screen, then disappear, then a few seconds later there are a few momentary vertical lines, then the cycle repeats. When I run the "with sound" code, I don't hear anything and no synthdefs seem to be generated.

@telephon
Copy link
Member Author

… sorry, try again if you like.

@mossheim
Copy link
Contributor

Ahhhh thank you! I definitely needed the "click and drag" instruction, hahaha. I had no idea these were interactive, although I probably should have guessed from seeing ".mouseUpAction_".

@mossheim mossheim merged commit d05ff0d into supercollider:master Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: help schelp documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants