class lib: Env:-kr/-ar : rename arguments to match functionality #2866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2858.
Issue
The old argument names were misleading.
EnvGen.kr/ar
actually use their 'mul' and 'add' for levelScale and levelBias, which are not the same thing.Solution
Rename them to match the corresponding arguments to EnvGen.ar/kr. Also update the documentation to reflect these changes. I chose this solution because it's the least intrusive and seemed to have general support.