Implement Symbol:isBinaryOp and Symbol:isIdentifier #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 15, 2017 09:55
This adds a list of characters that are valid in binary operators.
This commit implements Symbol:isBinaryOp via the primitive _Symbol_IsBinaryOp. For benchmarking purposes, this commit also includes Symbol:isBinaryOpLang, implemented natively.
This commit implements a method to check whether a symbol is a valid identifier (variable name) via the primitive _Symbol_IsIdentifier.
nhthn
added
the
comp: sclang
nhthn
force-pushed
the
topic/symbol-identifier-binaryop
branch
from
2facbf2
to
6b4d613
Compare
telephon
reviewed
Jun 15, 2017
|
sorry, what? |
|
sorry, I misread. Never mind! |
telephon
approved these changes
Jun 15, 2017
mossheim
reviewed
Jun 15, 2017
| @@ -179,6 +179,82 @@ int prSymbolIsMetaClassName(struct VMGlobals *g, int numArgsPushed) | |||
| return errNone; | |||
| } | |||
|
|
|||
| const char *binary_op_characters = "!@%&*-+=|<>?/"; | |||
There was a problem hiding this comment.
makes more sense as static within prSymbol_IsBinaryOp
There was a problem hiding this comment.
Sorry, should have been clearer—you can put them inside the function prSymbol_IsBinaryOp with the static storage classifier, and that means they are treated as init-once storage within the function but with local scope.
| SetTrue(a); | ||
| // All other characters must be alphanumeric or '_'. | ||
| for (int i = 1; i < length; i++) { | ||
| char the_character = str[i]; |
There was a problem hiding this comment.
'c' would be much more idiomatic here
Make a string static and change "the_character" to "c".
nhthn
force-pushed
the
topic/symbol-identifier-binaryop
branch
from
05742f5
to
3e0e7a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement #2952. we're going to be using these methods in SCDoc so why not make 'em faster with primitives. also, i need some experience writing primitives.
all documented, unit tested, and ready to go.