Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sclang debug posts on startup: "init_OSC", "initPassOne", "pass 1 done" #3135

Merged
merged 3 commits into from Aug 21, 2017

Conversation

nhthn
Copy link
Contributor

@nhthn nhthn commented Aug 19, 2017

this cherrypicks the most conservative commits out of #2431. this removes the following startup posts, which are not useful at all and were probably mistakenly left in:

init_OSC
initPassOne started
initPassOne done
pass 1 done

@nhthn nhthn added the comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library" label Aug 19, 2017
@nhthn nhthn added this to the 3.9 milestone Aug 19, 2017
@telephon
Copy link
Member

do we get an error message when osc init failed ?

Copy link
Contributor

@kisielk kisielk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@telephon If we did before, we still will, otherwise I think this has no effect on any error messages.

@mossheim mossheim merged commit fc5cbaa into supercollider:3.9 Aug 21, 2017
@telephon
Copy link
Member

so perhaps now we should, because we can't see that it has been initialized

@nhthn
Copy link
Contributor Author

nhthn commented Aug 25, 2017

@telephon the init_OSC message was printed before osc was initialized, so it didn't signify success, just "we entered the init_OSC function." also, we do have some error messages in this function.

either way, it's not always a good idea to print a message if something is successful. are there cases where sclang boots without osc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants