Join GitHub today
fix re-login behavior of remote clients to a server #3486
*** PR Info text completely redone ***
Case 1: network connection is lost,
Case 2: client crashes, and is restarted;
(Note for later: maybe develop functionality to retrieve these resources
Case 3: loss of connection and login from a different network address:
In the future, this case could be handled better by releasing the previous notify registration,
The tests provided also cover cases 1 and 2:
Just two quick questions @adcxyz:
If clientIDs are handed out by the server, then if the server recognises the client address, it can just give the same ID or? Or is this for the backwards compatible manually specified ID case?
Does it make sense that a client necessarily gets the same ID? If you have a lang crash, leaving orphaned nodes, then getting the same ID could lead to resource conflicts. There are various ways of dealing with that of course (e.g. gracefully free orphaned nodes using predictable default group), but you might want different ones for different use cases.
Yes, exaclty. This is what the server program has been doing all along, and I think is the clearest and most predictable behavior for most cases, as listed below.
I think keeping previously known IDs is the clearest and most predictable behavior for most cases I can think of:
hope that answers your questions?
Hi @brianlheim and @muellmusik,