Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
sclang: SequenceableCollection:unixCmd respects PATH #3501
This commit changes a call to execve to execvpe in SequenceableCollection:unixCmd, so that PATH is now respected.
This only affects *nix systems. SequenceableCollection:unixCmd is not currently supported on Windows, or so I hear.
once this method is working on Windows, i suggest that we refactor all calls to String:unixCmd to use this method. it is much better to call actual command line arguments as an array rather than formatting shell strings, which is vulnerable to injections.
execvpe isn't available on macos, it's a GNU extension.
IIUC you could just change this to
Since nothing is actually being added to