Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/fix helpbrowser #3832

Merged
merged 3 commits into from Jun 30, 2018
Merged

Topic/fix helpbrowser #3832

merged 3 commits into from Jun 30, 2018

Conversation

scztt
Copy link
Contributor

@scztt scztt commented Jun 30, 2018

No description provided.

@scztt scztt requested a review from jamshark70 June 30, 2018 00:17
jamshark70
jamshark70 approved these changes Jun 30, 2018
View reviewed changes
Copy link
Contributor

@jamshark70 jamshark70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works, seems OK to me.

@mossheim mossheim merged commit f61417c into develop Jun 30, 2018
@mossheim mossheim added the comp: Qt GUI sclang Qt components -- for IDE tickets, use "env: SCIDE" instead label Jun 30, 2018
@mossheim mossheim deleted the topic/fix-helpbrowser branch June 30, 2018 16:04
@nhthn
Copy link
Contributor

nhthn commented Jul 2, 2018

has the helpbrowser been broken since 3.9, or is this breakage a recent thing?

@jamshark70
Copy link
Contributor

This particular breakage is new (with the update to WebEngine).

However, the browser was broken for a very long time because clicking on a link wouldn't call the sclang action, so help files wouldn't be rendered automatically. The fix for that issue was postponed, in hopes that WebEngine would fix it (which it does).

@nhthn nhthn added this to the 3.10 milestone Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamshark70 jamshark70 jamshark70 approved these changes

Assignees
No one assigned
Labels
comp: Qt GUI sclang Qt components -- for IDE tickets, use "env: SCIDE" instead
Projects
None yet
Milestone
3.10
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@scztt @nhthn @jamshark70 @mossheim