docs: match code syntax highlighting from the default theme #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htor
changed the title
telephon
approved these changes
Jul 16, 2018
nhthn
added
the
comp: SCDoc
patrickdupuis
suggested changes
Jul 17, 2018
HelpSource/lang-sc.js
Outdated
| [PR.PR_ATTRIB_NAME, /^\\\w+/], | ||
| [PR.PR_ATTRIB_NAME, /^'[^']+'/], | ||
| [PR.PR_ATTRIB_NAME, /^\w+\:/], | ||
| [PR.PR_ATTRIB_NAME, /^\$(\\)?./], |
There was a problem hiding this comment.
Could you remove the extra white space here?
There was a problem hiding this comment.
yes, done! i force-pushed the change, maybe not the way to do it.
There was a problem hiding this comment.
You can push a new commit to your remote topic/docs-syntax-hi branch and it will be added to this PR. No force pushing required. We have the option of squashing a PR to keep the commit history clean when merging.
There was a problem hiding this comment.
@patrickdupuis i already did a push -f overwriting this commit with the change, so it can be used for a merge.
patrickdupuis
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syntax highlighting for code in the help/docs is different (but confusingly similar) from the default theme in the editor. for consistency, colors and font weights are adjusted to be the same.
before:
after:
the careful eye will notice that the editor has slightly lighter tone than the docs.
i wasn't able to translate that from qt into css, but if it's significant i might do it.
the default theme: https://github.com/supercollider/supercollider/blob/develop/editors/sc-ide/core/settings/theme.cpp#L101. testing the docs theme: https://github.com/supercollider/supercollider/blob/develop/HelpSource/syntax_colors.html