[class library] new _FileDeleteAll primitive

[mkb218]

Purpose and Motivation

Recursive delete of a pathname. Fixes #3651.

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist

• All tests are passing

• If necessary, new tests were created to address changes in PR (and tests are passing)

• Updated documentation, if necessary

• This PR is ready for review

[mossheim]

Thanks @mkb218 ! This code is clear and stylistically perfect.

My concern with this approach is that any error message coming from remove_all is hidden. To make this method orthogonal with the other File operations, I'd recommend:

• use the non-error_code version of remove_all, so that encountered errors will be caught and reported by the runtime
• set the return value using the bool return value of remove_all.

I think this addition is fine without a test; we currently don't test filesystem operations and I think unless we run into anything significantly annoying, it's more trouble than it's worth. So I've marked this as OK on the test requirement.

Please also add documentation in HelpSource/Classes/File.schelp.

If you have any questions, let me know!

[mkb218]

I think I've implemented your recommendations, but now this method's return value is inconsistent with File.delete

[mossheim]

@mkb218 That's fine, thanks for the changes! Could you also update the documentation with information about the error throwing conditions?

[mossheim]

Overall looks good, but I think you accidentally committed some changes to hidapi as well, can you please revert that and then I'll approve this?

[mkb218]

Oops! Hang on while I try to get git to forget about that.

[mkb218]

OK, I think this is ready!

[nhthn]

thanks! sorry, but could you rebase to get rid of the revert commits?

[mkb218]

No problem! I'll just squash it into a single commit?

[nhthn]

yes, i think that would be appropriate here.

[mossheim]

thanks!

[mossheim]

Didn't realize this returns a uint - I was reading the doc for remove by mistake!

[mkb218]

@snappizz should be all set now

Concerns have been addressed.

[prko]

thank you!