remove unnecessary std::move according to clang 8.0 compiler warnings #4274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@geoffroymontel can you please rebase this on 3.10? |
geoffroymontel
force-pushed
the
fixes/remove-unnecessary-std-move
branch
from
8169905
to
74a8968
Compare
|
@brianlheim thanks for the review, it is now rebased. |
mossheim
approved these changes
Jan 25, 2019
nhthn
approved these changes
Jan 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
The goal is to remove compiler warnings (see #2927)
Types of changes
Remove std::move calls where clang 8.0 warned them as unnecessary
To-do list