fix misconnected slot in WebView

[patrickdupuis]

Purpose and Motivation

This PR fixes an error message that is posted when opening HelpBrowser.instance in command line sclang.

QObject::connect: No such slot QtCollider::WebView::onRenderProcessTerminated(RenderProcessTerminationStatus, int)

Adding a new SLOT called onRenderProcessTerminated to the WebPage class seems to fix this. I've also specified that this SIGNAL and corresponding SLOT take a QWebEnginePage::RenderProcessTerminationStatus as first argument.

@jrsurge posted a proper fix in his comment. I've updated the PR accordingly.

Possibly related to some behaviour mentioned in #4256 This PR isn't a fix for any specific issue.

Types of changes

• Bug fix

To-do list

• Code is tested
• All tests are passing
• Updated documentation
• This PR is ready for review

[jrsurge]

The current solution creates a new signal and connects that to the slot.
This will clear the error message, because it's a valid connection, but it's not the signal being emitted by the internal QWebEnginePage methods, so it will never actually get triggered.

The only way I can make this work is to use the functor-style connection (from Qt 5.x) rather than the older string-style approach. The functor-style can resolve namespaces and do implicit conversions, which is what is required here. For reference: https://doc.qt.io/qt-5/signalsandslots-syntaxes.html

Using the functor-style, the only change required should be:

- connect(page, SIGNAL(renderProcessTerminated(RenderProcessTerminationStatus, int)), this,
-            SLOT(onRenderProcessTerminated(RenderProcessTerminationStatus, int)));
+ connect(page, &WebPage::renderProcessTerminated, this, &WebView::onRenderProcessTerminated);

As a bonus, it looks a lot cleaner too?

[patrickdupuis]

Awesome @jrsurge! I'll give it a try and update the PR.

[mossheim]

awesome, thanks!