Support for Boost 1.71 #4612
Merged
Support for Boost 1.71 #4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
all good |
|
Note that I also need #4611 to build develop branch on macOS + xcode 11. After merging that, 3.10 should be merged into dev ASAP. |
|
this should go to 3.10 branch not develop per today's discussion |
nhthn
previously requested changes
Nov 19, 2019
|
@snappizz what is the rationale behind this though? |
|
@dvzrv branches should be made against 3.10 if they are uncontroversial bug fixes with no risk. brian and i talked about this at the last dev call and we agreed this PR should be based on 3.10 and not develop, the above are just a reminder of our decision until he gets around to it |
|
updated, sorry for the delay, forgot about this for a while! |
class hierarchy changed. this change is at least backward compatible with 1.70 tested with boost 1.66, 1.71
nhthn
approved these changes
Dec 14, 2019
This was referenced Dec 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
Fixes #4576, #4490
I looked for a nicer way to to this, but couldn't find anything -- there appears to have been a single boost release (1.70) where this class hierarchy was somewhat compatible in both directions.
Types of changes
To-do list