Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scide: Reinstate translations files in distributions. #4810

Merged
merged 1 commit into from Mar 14, 2020
Merged

scide: Reinstate translations files in distributions. #4810

merged 1 commit into from Mar 14, 2020

Conversation

claremacrae
Copy link
Contributor

Purpose and Motivation

This fixes #4809 - which is that a change I made previously had stopped the translations/scide_*.qm files from being added to distributions.

Types of changes

  • Bug fix

The fix was to make the sc-ide exe depend on the translation files, instead of the libscide library...

To-do list

  • Code is tested - tested by creating a distribution on Mac and checking it had the translations folder
  • All tests are passing - based on the belief that there are no tests for this issue (as it hasn't been reported)
  • Updated documentation - not sure that there is any documentation to change?
  • This PR is ready for review

@claremacrae claremacrae mentioned this pull request Mar 9, 2020
Merged
4 tasks
@claremacrae claremacrae changed the title Reinstate translations files in distributions. scide: Reinstate translations files in distributions. Mar 9, 2020
mossheim
mossheim suggested changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@mossheim mossheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm this works. will wait until CI is fixed to merge as it's conceivable this could affect other builds in an unexpected way

@mossheim mossheim merged commit eedeb8d into supercollider:develop Mar 14, 2020
@mossheim mossheim mentioned this pull request Apr 11, 2020
Merged
@patrickdupuis patrickdupuis moved this from TODO to in progress in Patch release cherry-picks Jul 6, 2020
@patrickdupuis patrickdupuis moved this from in progress to DONE in Patch release cherry-picks Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mossheim mossheim mossheim approved these changes

Assignees
No one assigned
Labels
env: SCIDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

translations folder missing from distributions since libscide introduced
2 participants
@claremacrae @mossheim