New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HiDPI fractional scaling: remove rounding to int #4846
Conversation
@elgiano thanks for this! just want to note that appveyor CI failing is not your fault, it's an unrelated issue that i'm working to resolve. |
I'm adding Qt::AA_EnableHighDpiScaling in two places: one for sclang and one for scide. The benefit (on Linux) is that scide and sclang figure out how to scale themselves automatically, without me needing to set any env var (which I can still do if I want things different). @dyfer lets set up something on slack and test it out? |
4fd0ae7
to
9987493
Compare
@elgiano if you're going to do more work/testing on this it would be good to split it into 2 PRs at this point before it gets messy :) |
@brianlheim I agree. |
9987493
to
77fd992
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on macOS and it works fine, i.e. does not introduce any side effects in the sclang GUI.
For the record, this will also be needed in addition to #4850 for non-integer scaling (125/150/175%) on Windows (and possibly Linux?)
looks good, thanks! |
Purpose and Motivation
Fixes #4844
Types of changes
To-do list
Specific testing would require changing the user's HiDPI settings, which can't be done from sc