classlib: move plotter deprecation into GUI subfolder #4875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise non-GUI build breaks with an extension to non-existing class
Closed
|
i would like to add a check to CI to try launching sclang so this kind of thing can be caught in the future, but i don't have time to do it at the moment, sorry |
|
you can see in this older GUI-less build of 3.11, in the GUI-less build from this PR, it is not: https://travis-ci.org/github/supercollider/supercollider/jobs/675151285#L2567 |
dyfer
approved these changes
Apr 15, 2020
|
Thanks @brianlheim ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
otherwise non-GUI build breaks with an extension to non-existing class
see musikinformatik/SuperDirt#192 (comment)
FYI, in a non-GUI build any folder named "GUI" is skipped when installing the class library. it happens in the build system, here:
supercollider/CMakeLists.txt
Line 455 in 31c0c93
Types of changes
To-do list
couldn't find it. does anyone know where it is? if not i'll add a section to the reviewer instructions.