servers: fix unicode support for mingw #4926
Conversation
server/supernova/CMakeLists.txt
Outdated
| @@ -206,6 +206,7 @@ target_link_libraries(supernova libsupernova) | |||
|
|
|||
| if(WIN32) | |||
| if(NOT MSVC) | |||
| SET(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -municode") | |||
There was a problem hiding this comment.
using SET in this way is very old-style cmake. i think you want target_link_libraries instead.
also, this will add this flag for MSYS builds too, do you know if that's a problem? i am not familiar enough with these systems to know but just thought i would ask. if you don't know, don't worry about it. @sonoro1234 may know?
There was a problem hiding this comment.
I dont use MSYS just mingw-64 gcc compiler from windows command line!!
I guess @dyfer tested the flag already
There was a problem hiding this comment.
thanks! in that case don't worry about MSYS support @dyfer
dyfer
force-pushed
the
topic/mingw-unicode
branch
from
376fb0a
to
30ad6c6
Compare
|
Thanks for the note on I still need to test this after this change. |
|
oh darn, sorry, i just saw "I still need to test this"... please do test this if you have time, we can always open a new PR if it didnt work. |
|
tested - works :) |
|
thank you! |
Purpose and Motivation
MinGW needs this flag since we are now using
wmain()in servers.Types of changes
To-do list