Merge 3.11 into develop #5223
Merged
Merge 3.11 into develop #5223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connected to Issue #4573: it should be explicitly stated if a function checks for equality or identity. A lot of the examples used the shortcut for initializing an event, which leads to a different behaviour regarding checks for equality. So I decided to also change all the examples to use a correct initilization for creating a dictionary object.
Pattern.record used to simply ignore header and sample format provided as arguments
- this also contains a change to how the result of a javascript call is returned to SC w/r/t QVariant and meta-type system, see https://github.com/supercollider/supercollider/pull/4883/files#r509325677 for more discussion - fixed code execution in both HelpBrowser class and Widget + in WebView, if the rendered webpage has selectLine()/selectRegion() javascript functions. It works with selected text/line, and with selected text/region. - code execution in webviews is more consistently delegated to javascript, calling a function to get selected text, receiving it in a callback and then sending it to the interpreter - a workaround WebView's "funny" keypress behavior, now keyDownAction works on WebView only when an url is set. It gets all events (including the ones swallowed by the renderer) without duplication. WebView parent widgets also get all keystrokes, except the ones swallowed by the web renderer when focusing an input field (like Shift+Enter). - Using QcWebView in ScIDE Help Browser Widget
"radians" not "radiants"
[3.11] cherry-pick documentation PRs for 3.11.2
…ctional [3.11] Cherry-pick several functional PRs for 3.11.2
Prepare for 3.11.2-rc1
|
I don't understand the diff here either. |
|
@dyfer ok! mind approving this then? |
dyfer
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
regular git-flow merge of 3.11 into develop
To-do list