Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS info.plist: add microphone access prompt #5356

Merged

Conversation

dyfer
Copy link
Member

@dyfer dyfer commented Feb 15, 2021

Purpose and Motivation

On macOS, builds with Qt 5.15.2 were not triggering the "Microphone permissions" dialog in Catalina and Big Sur, and thus did not have access to audio input.

Adding the appropriate field to the info.plist file seems to fix this issue. In my testing with this fix SC asks for correct permissions whether the build is signed or not.

Thanks @brianlheim for suggesting this!

Types of changes

  • Bug fix

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

Copy link
Contributor

@mossheim mossheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mossheim mossheim merged commit 3da48d6 into supercollider:develop Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: build CMake build system os: macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants