[scide] Fix classname highlighting before introspection available #5438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrsurge
changed the title
jrsurge
added
bug
joshpar
reviewed
May 3, 2021
| @@ -89,7 +89,7 @@ class SyntaxHighlighter : public QSyntaxHighlighter { | |||
| SyntaxHighlighter(QTextDocument* parent = 0); | |||
|
|
|||
| private: | |||
| void highlightBlock(const QString& text); | |||
| void highlightBlock(const QString& text) override; | |||
There was a problem hiding this comment.
I'm curious - why is the override keyword needed now and not before? Or - was part of the problem that this wasn't marked as override properly?
There was a problem hiding this comment.
it wasn't there before, this is very much a "leave the code better than you found it" commit
joshpar
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
This aims to fix issue #5434.
Introduced in #4890 on develop, classnames would not highlight correctly if a file was opened before introspection was available.
This PR prevents highlighting until introspection is available, and triggers highlighting when introspection changes.
Why did this break?
The classname highlighting was broken and formatted everything beginning with an uppercase letter.
The changes in #4890 mean that classnames now have to exist before being highlighted, which means we need to wait for introspection before highlighting them.
Why not use the old behaviour until introspection is available?
It would highlight things incorrectly and then magically correct itself, which could be confusing.
Why not highlight everything else and only highlight classnames when introspection becomes available?
Ultimately, I think it would be more confusing to have a file partially highlight and then have things magically appear.
Old behaviour
New behaviour
Types of changes
To-do list