Made Supernova bind to the specified address, instead of always liste… #5474
Conversation
…ning on all interfaces.
|
Opened an issue to discuss the potential shmem collision: #5475 |
|
Just realized that this fix doesn't work with ipv6 and that I should validate address early, as suggested in @brianlheim's comment. Will correct this ASAP. |
The bind address is validated at command line argument parse stage now.
|
I fixed ipv6 issue and corrected my code formatting. Hopefully it'll pass the tests |
|
Thank you! This works as advertised, tested on macOS. I'd like for someone else to also look over this PR before approving/merging. |
|
Cool! Glad it works on macOS as well. Since you added it to 3.12.0 milestone, should I write that version in the updated documentation? I used "3.12.x" as a placeholder. |
|
@laserbat good point about the docs. Just FYI we weren't planning on getting any new PRs into 3.12, but since it changes the default behavior (and tightens security, and makes supernova behave the same as scsynth) I think it would be desirable to include it. In that case yes, the docs could be changed stating that the old behavior was in place "Before SuperCollider 3.12" (or 3.12.0). I also think "before" is better than "until" since reading it I wouldn't be sure if the latter means including or excluding that version. But that's a really minor thing, feel free to phrase it the way sounds good to you. |
|
I see. Thanks for clarifying this, I will update the documentation in a few minutes :) |
…ning on all interfaces.
Purpose and Motivation
Fixes #4864
Supernova currently binds to 0.0.0.0 regardless of address provided in arguments. This PR makes it honor user supplied address, as well as binding on 127.0.0.1 by default.
As @brianlheim pointed out in #4864, this fix can potentially cause issues if there are multiple supernova servers running on same port but different interfaces. I think it's worth to create a separate issue to discuss how this can be fixed, possibly in a different PR.
Types of changes
This PR changes the default (insecure) behavior, by making supernova listen on 127.0.0.1 when no address is supplied. The security improvement, as well as making supernova behave more like scsynth should justify this change.
To-do list