Git submodules: update urls to use https #5694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
required by the security improvements, see https://github.blog/2021-09-01-improving-git-protocol-security-github
josiah-wolf-oberholtzer
approved these changes
Jan 11, 2022
jrsurge
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
Fixes #5693
GitHub made changes to improve security, deprecating the use of
git://protocol. Our builds started to fail because of this, since the submodules were not being fetched. The solution is to update the submodule URLs to usehttps://.See https://github.blog/2021-09-01-improving-git-protocol-security-github for more details.
Updating forks
After this change is pulled in, all repository users should update their forks to pull in the fix and then run
git submodule syncafterwards to update the URLs in the local repository.Types of changes
To-do list