Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed white space in brackets printed on the post window. #6106

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

prko
Copy link
Contributor

@prko prko commented Oct 4, 2023

This PR is a correct PR (based on my branch) of the following closed wrong PR (based on the develop branch):

#6105

Purpose and Motivation

The post window output of the collection's subclasses does not follow the recommended code style.
This PR makes these post-window outputs follow the recommended code style, so that users can use the post-window output in new code without removing whitespace.

Please see the following scsynth forum thread:

https://scsynth.org/t/array-recommended-style-of-code-and-how-to-return-to-the-post-window/8310

Types of changes

  • minor but practical change

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation <- not required
  • This PR is ready for review

@prko
Copy link
Contributor Author

prko commented Oct 4, 2023

@dyfer @cdbzb I think I did what you pointed out correctly this time, but I would ask you to check if I really did. I apologise for any inconvenience.

@dyfer
Copy link
Member

dyfer commented Oct 16, 2023

Thanks @prko! The PR (branches etc) looks fine now.

At the dev meeting on 2023-10-08 we discussed that this PR is 1) technically a breaking change, since the generated code with .storeOn would change, but 2) since this is a whitespace change, it should not actually break any reasonably written code.

I'll pull this in now.

However, we should review other uses of storeOn/printOn to potentially provide a similar fix, for consistency. I'm planning to do that.

Copy link
Member

@dyfer dyfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dyfer dyfer merged commit 9640dbc into supercollider:develop Oct 16, 2023
75 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants