New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement replace regex using boost #6213
base: develop
Are you sure you want to change the base?
Implement replace regex using boost #6213
Conversation
Does anyone know if the object previously at the return slot needs to be free'd manually gc? Edit: no it doesn't |
I would guess not because of GC. But I have a question. When the code runs into a problem, like receiving the wrong type of data or encountering an issue while processing a regular expression, is SetNil(slot_this) enough? if some data to return but then hits a snag, does the cleanup system still works without manually deallocating output_string? In other words, was it assigned to a slot for GC to manage? (This is not a review, but just a question) |
I have no idea... just copied to conventions in the other primitives 🙂 |
Coming back to this after learning more... in his case no it doesn't because there isn't any point of failure between creating the string and assigning it to a slot, but in general yes. It is quite common to push any temporary variables onto the end of the stack for this reason. |
I've updated this now with tests and documentation. |
Purpose and Motivation
https://scsynth.org/t/testing-a-draft-of-replaceregexp
Types of changes
To-do list