Add bounds arg to {}.scope & s.plotTree

[prko]

Purpose and Motivation

This PR is a part of #6230

Types of changes

• Documentation
• New feature

To-do list

• Code is tested
• All tests are passing
• Updated documentation
• This PR is ready for review

[prko]

@mtmccrea

Hi, I think I split #6230 as you advised.
However, {}.scope(bounds: ... ) in this PR does not work because of the following line:

supercollider/SCClassLibrary/Common/GUI/PlusGUI/Control/server-scope.sc

Line 48 in 96eafe3

server.scope(numChannels, outbus, bufsize, zoom, outUGen.rate, bounds);

This line should be changed as follows:

server.scope(numChannels, outbus, bufsize, zoom, outUGen.rate). bounds_(bounds); 

However, #6281 should be approved and merged first.

Um... I have two questions:

• Should I wait for add .bounds_ method to Stethoscope #6281 to be merged, or should I change it now?
• Should I split this PR again as follows?
  • Add bounds arg to {}.scope
  • Add bounds arg to s.plotTree;
  • Make s.plotTree a singleton window

[mtmccrea]

However, #6181 should be approved and merged first.
... should I change it now?

That's fine, you can change it now and just make a note of that in the PR description above, and we can put the has merge note tag on this.

Please add a description to this PR. The reason for breaking up the previous PR was to simplify it by having smaller standalone PRs, so this will need a standalone description of the changes. It's of course OK to reference it for context, but shouldn't rely on it.

Should I split this PR again as follows?

It's ultimately up to you to decide which changes are similar enough to "belong" together. Just know that someone may object to one but not all changes, and that objection will hold up the review of all of them. For example, is Make s.plotTree a singleton window related to or required for setting its bounds? (I'm not sure because there is no description).

[prko]

Thanks for adding has merge note.

is Make s.plotTree a singleton window related to or required for setting its bounds?

Making s.plotTree a singleton window is a separate issue from adding the bounds argument.

Currently SuperCollider makes s.plotTree every time it evaluates s.plotTree. I think this behaviour should be changed, and I changed it when I added the bounds argument. It is technically in a different category, so it should be written with a separate PR. However, I thought it was better to make one complex PR rather than many PRs with a tiny change.

If you like it, I will split it.

After splitting it again, the original PR is split into 5 PRs.

(
Technically, this PR should be split into three:

1. add bounds arg to {}.scope;
2. add bounds arg to s.plotTree;
3. make s.plotTree a singleton window...

Oh... the thing I thought was one is actually 6 things. Sorry again, I misunderstood submitting PR when I did it
)

[mtmccrea]

Making s.plotTree a singleton window is a separate issue from adding the bounds argument.

Then it should probably be a different PR

BTW some git concepts like rebasing, branching, squashing that may help you with this kinds of project splits and updates. There is info on our wiki, and I recently make a tutorial on using GitHub Desktop for this kind of thing.

[prko]

Thanks! I will do it!

[prko]

@mtmccrea

Then it should probably be a different PR

I spilt only making .plotTree singleton Window from this PR.
It has now one more Merge Note:
When this PR is approved or merged, the following PR should be checked to see if each of them has already been approved or merged.

• make .plotTree a single instance window and add ServerTreeView #6294
• add .bounds_ method to Stethoscope #6281 (This should be approved and merged before this PR.)