asSynthDef and SynthDef.name should return symbols #661

Merged
merged 3 commits into from Nov 25, 2012

Projects

None yet

2 participants

@timblechmann

comments?

@telephon
Member

Reading through it, I think it is good and should be done.
It would be good if you stated in the commit message why you did these changes.

On 22.11.2012, at 22:11, Tim Blechmann notifications@github.com wrote:

comments?

You can merge this Pull Request by running:

git pull https://github.com/timblechmann/supercollider topic/asSynthDef_symbol
Or view, comment on, or merge it at:

#661

Commit Summary

• sclang: increase initial size of symbol table
• class library: SynthDef - convert SynthDef name and asDefName to Symbol
• class library: Event - allow objects responding to asDefName as instr…
File Changes

• M SCClassLibrary/Common/Audio/SynthDef.sc (19)
• M SCClassLibrary/Common/Audio/SynthDefOld.sc (26)
• M SCClassLibrary/Common/Collections/Event.sc (16)
• M SCClassLibrary/Common/Control/asDefName.sc (14)
• M lang/LangSource/PyrLexer.cpp (2)
Patch Links

https://github.com/supercollider/supercollider/pull/661.patch
https://github.com/supercollider/supercollider/pull/661.diff

Reply to this email directly or view it on GitHub.

timblechmann added some commits Nov 22, 2012
@timblechmann timblechmann sclang: increase initial size of symbol table
prevent some rehashing at startup

Signed-off-by: Tim Blechmann <tim@klingt.org>
44f1e69
@timblechmann timblechmann class library: SynthDef - convert SynthDef name and asDefName to Symbol
the SynthDescLib uses Symbols as keys, while SynthDef and asDefName used
Strings as name. this commit fixes this inconsistency.

Signed-off-by: Tim Blechmann <tim@klingt.org>
e53221c
@timblechmann timblechmann class library: Event - allow objects responding to asDefName as instr…
…ument

Signed-off-by: Tim Blechmann <tim@klingt.org>
9e4c080
@timblechmann timblechmann merged commit 99b1ba0 into supercollider:master Nov 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment