feat(config): allow config changes without rebuilt #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it will load `config.js` as well as app.bundle where user can set `superdeskConfig` dict which will be used to update config before `angular.bootstrap`. there is empty file provided in core by default, but will use `config.js` file from `superdesk/client` if any. SDESK-577
vied12
approved these changes
Jan 13, 2017
naspeh
approved these changes
Jan 13, 2017
There was a problem hiding this comment.
Checked on https://sdcpr-1251.test.superdesk.org, wrote the comment in JIRA.
it works great, thanks @petrjasek
|
It would be nice to have that fix also in publisher branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it will load
config.jswhere user can setsuperdeskConfigdictwhich is used to update config before
angular.bootstrap.there is empty file provided in core by default, but will use
config.jsfile fromsuperdesk/clientif any.SDESK-577