Grayscale #50
Merged
Grayscale #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 29, 2021 15:04
neweyes
reviewed
Mar 3, 2021
| @@ -31,6 +31,8 @@ const ( | |||
| GridSelectorName = "superedge.io/grid-selector" | |||
| // GridSelectorKey corresponds to gridUniqKey of the custom-defined workload | |||
| GridSelectorUniqKeyName = "superedge.io/grid-uniq-key" | |||
| // TemplateHashKey is a key for storing template's hash value in labels. | |||
| TemplateHashKey = "service_group_template_hash_key" | |||
There was a problem hiding this comment.
please rename “ service_group_template_hash_key”，keep the same format with GridSelectorName and GridSelectorUniqKeyName
neweyes
reviewed
Mar 3, 2021
| "hash/fnv" | ||
| ) | ||
|
|
||
| func GenerateHash(template interface{}) uint64 { |
There was a problem hiding this comment.
Uint64 has a small range and is prone to hash collision. Please pay attention to user feedback
|
/lgtm |
00pf00
pushed a commit
to 00pf00/superedge
that referenced
this pull request
May 20, 2021
* add protocol required * deploymentgrid grayscale * statefulsetgrid grayscale * add copyright&fix bug * gofmt * file mode * grayscale doc * rename Signed-off-by: 00pf00 <feeli202012@gmail.com>
00pf00
pushed a commit
to 00pf00/superedge
that referenced
this pull request
May 20, 2021
* add protocol required * deploymentgrid grayscale * statefulsetgrid grayscale * add copyright&fix bug * gofmt * file mode * grayscale doc * rename Signed-off-by: 00pf00 <feeli202012@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
#24