Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] Coverage tests don't work when running in parallel #1591

Closed
0xdavinchee opened this issue Aug 17, 2023 · 1 comment
Closed

[ETHEREUM-CONTRACTS] Coverage tests don't work when running in parallel #1591

0xdavinchee opened this issue Aug 17, 2023 · 1 comment
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Severity: Medium Tag: Blocked The issue is blocked by other issues Tag: TechDebt Technical debt that needs to be addressed Type: Testing Testing cases or harness improvements

Comments

@0xdavinchee
Copy link
Contributor

0xdavinchee commented Aug 17, 2023 •
edited by hellwolf
Loading

Problem

When trying to run the coverage tests with parallel: true in hardhat.config.ts under the mocha property, the tests break complaining about the code size being too large despite it working fine if the tests are not running in parallel.

I have notified the Hardhat team regarding the issue, here here and hopefully they may have more insight into it.

Impact: it slows down the merge queue throughput due to slow testing time.
@0xdavinchee 0xdavinchee added Type: Testing Testing cases or harness improvements Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity labels Aug 17, 2023
@hellwolf hellwolf mentioned this issue Aug 23, 2023
Closed
@hellwolf hellwolf added Tag: TechDebt Technical debt that needs to be addressed Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Severity: Medium labels Aug 23, 2023
@hellwolf hellwolf removed the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Mar 11, 2024
@hellwolf hellwolf added the Tag: Blocked The issue is blocked by other issues label Jul 12, 2024
@hellwolf hellwolf closed this as completed Sep 2, 2024
@hellwolf
Copy link
Contributor

hellwolf commented Sep 2, 2024

for reference: to be resolved/followed here NomicFoundation/hardhat#4492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Severity: Medium Tag: Blocked The issue is blocked by other issues Tag: TechDebt Technical debt that needs to be addressed Type: Testing Testing cases or harness improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hellwolf @0xdavinchee