Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETHEREUM-CONTRACTS] Add decimals as an option to deploy-test-token.js #994

Closed
1 of 2 tasks
0xdavinchee opened this issue Jul 25, 2022 · 0 comments · Fixed by #1025
Closed
1 of 2 tasks

[ETHEREUM-CONTRACTS] Add decimals as an option to deploy-test-token.js #994

0xdavinchee opened this issue Jul 25, 2022 · 0 comments · Fixed by #1025
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Size: S Type: Testing Testing cases or harness improvements
Projects

Comments

@0xdavinchee
Copy link
Contributor

0xdavinchee commented Jul 25, 2022

Summary

Currently our deploy-test-token.js script hardcodes the number of decimals to 18 when deploying the TestToken contract.
However, @kasparkallas brought up a good point which is that there are many ERC20 tokens in the wild which are part of our resolver and prevalent in crypto (USDC) which have a different number of decimals.
Allowing the deployment of test token with a custom number of decimals is going to be useful for testing logic along the entire stack (contracts to client) and we should consider redeploying the fUSDC tokens in the testnets which won't be deprecated with the correct number of decimals (6) so we can properly test this logic internally as well as allowing external devs building on top of Superfluid to have a more realistic testing experience.

TODO

  • Allow another property to be included when running deploy-test-token.js: TOKEN_DECIMALS, if it is left empty, default to the standard 18
  • (OPTIONAL) Redeploy fUSDC with 6 decimals and remove the current fUSDC from the resolver and add this one to the resolver
@0xdavinchee 0xdavinchee added Type: Testing Testing cases or harness improvements Size: S Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity labels Jul 25, 2022
@hellwolf hellwolf added this to Backlog in PROTO Jul 26, 2022
@0xdavinchee 0xdavinchee linked a pull request Aug 9, 2022 that will close this issue
PROTO automation moved this from Backlog to Done Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Size: S Type: Testing Testing cases or harness improvements
Projects
No open projects
PROTO
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant