add tokenDecimals option to deploy-test-token.js #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
📦 PR PackagesInstall this PR (you need to setup Github packages): yarn add @superfluid-finance/js-sdk@PR1025
yarn add @superfluid-finance/ethereum-contracts@PR1025
yarn add @superfluid-finance/sdk-core@PR1025
yarn add @superfluid-finance/sdk-redux@PR1025
yarn add @superfluid-finance/hardhat-deployer@PR1025
|
Click to learn how to use Github packages
hellwolf
reviewed
Aug 9, 2022
| @@ -16,7 +16,7 @@ const { | |||
| * @param {Address} options.from Address to deploy contracts from | |||
| * @param {boolean} options.resetToken Reset the token deployment | |||
| * | |||
| * Usage: npx truffle exec scripts/deploy-test-token.js : {TOKEN_SYMBOL} | |||
| * Usage: npx truffle exec scripts/deploy-test-token.js : {TOKEN_DECIMALS} {TOKEN_SYMBOL} | |||
There was a problem hiding this comment.
appending the arg and making it optional (keep default value) would have avoided breaking the interface
hellwolf
approved these changes
Aug 9, 2022
XKCD Comic RelifLink: https://xkcd.com/1025 |
jtriley-eth
added a commit
that referenced
this pull request
Aug 10, 2022
* Release hardhat deployer stable (#1009) * Add resolver and loader to deployer, add tests (#1011) * actions/setup-node cache property added (#1002) * Remove redundant deployments (#1014) * specify cache-dependency-path (#1018) * Ethereum 1.3.1 - for hardhat deployer update (#1016) * Update CHANGELOG.md * bump ethereum-contractw to 1.3.1 * Update CHANGELOG.md * Fix release branch (#1024) * add tokenDecimals option to deploy-test-token.js (#1025) * Map indexId to IndexSubscription (#1026) * bump contract version, add test for loader (#1028) Co-authored-by: 0xdavinchee <0xdavinchee@gmail.com> Co-authored-by: Miao ZhiCheng <miao@superfluid.finance> Co-authored-by: Kaspar Kallas <kaspar@superfluid.finance>
0xdavinchee
added a commit
that referenced
this pull request
Oct 17, 2022
* Subgraph data integrity validation (#661) * Update dependencies (#930) * Disable public shaming during weekends and some more data to slack bot (#947) * Minor command update (#948) * ci.feature + ci.canary cleanup (#949) * [SDK-redux] Update example project references and add back WalletConnect (#942) * Create Hardhat Deployer (#950) * Update ci.canary.yml (#952) * Resolver Set + Workflow Modifications (#951) * add SetEvent to getAllEvents query (#953) * Subgraph 1.4.4 Release Bump | SDK-Core 0.4.5 Release Bump (#955) * Initialize logic contracts on deployment (using "castrate") (#841) * [SDK-core] Compile AJV validations (#954) * SDK-Core Build Fix (#963) * [EXAMPLES] Fix sdk initializations (#946) * bump sdk-core version to 0.5.0 (#964) * isNativeAssetSuperToken added to Token entity (#968) * Adds a missing closing parenthesis to example test (#967) * [SDK-core] Refactor SFError to follow more conventional Error object structure (#960) * Addresses several shortcomings in current worflows (mainly mainnet related) (#911) * Add back the serialized error to SFError's message (#978) * SDK-Core - isNativeAssetSuperToken query support (#970) * [SDK-core] Use `serialize-error` (#983) * fix handler.publish-release-packages (#985) * Add missing stringify (#988) * create operation from framework (#984) * Test Framework Created Operation + Remove isNativeAssetSuperToken from query (#989) * SDK-Core `isNativeAssetSuperToken` support (#992) * bump subgraph and sdk-core versions for dev (#998) * [spec-haskell] agreement framework refactored (#987) * Update ci.canary.yml (#1000) * [SDK-Core] Call App Action Support Added/Fixed CallAppAction BatchCall (#995) * SDK-Core 0.5.2 Patch Fix and Version Bump (#1001) * Update cd.hardhat-deployer-stable.create-release-drafts.yml (#1006) * Release hardhat deployer stable (#1009) * Add resolver and loader to deployer, add tests (#1011) * actions/setup-node cache property added (#1002) * Remove redundant deployments (#1014) * specify cache-dependency-path (#1018) * Ethereum 1.3.1 - for hardhat deployer update (#1016) * Fix release branch (#1024) * add tokenDecimals option to deploy-test-token.js (#1025) * Map indexId to IndexSubscription (#1026) * bump contract version, add test for loader (#1028) * New TestSuperApp: stream redirector wip (#1008) * #899 App Credit Rule CFA-2 (#945) * [Sk-core patch fix (#1035) * Adding Constant Flow Distribution Agreement etc. (#1017) * Remove pesky error messages that and update readme (#1037) * kwik patch (#1040) * Deprecate networks (#1032) * [TOGA] Added missing awaits (#1044) * [SDK-core] Don't wrap transaction errors with `SFError` & don't serialize a massive internal error into `SFError` message (#1046) * [SUBGRAPH] Update addresses.template.ts (#1047) * Remove examples folder (#1045) * [SDK-core] Specify name property for `SFError` (#1048) * [ETHEREUM-CONTRACTS] Add gnosisscan support (#1050) * Update README to link to examples repo (#1051) * Fix the precious slack bot message (#1053) * Update CHANGELOG.md (#1055) * [ETHEREUM-CONTRACTS] Gov: Convenience method for app registration keys and some cleanup (#1049) * remove hardhat deployer (#1057) * [ETHEREUM-CONTRACTS] CFA Agreement Forwarder (#982) * Remove MaticBridgedToken from monorepo (#1060) * [ETHEREUM-CONTRACTS] Add Custom Errors (#1043) * [ETHEREUM-CONTRACTS] yAcademy Gas Savings Applied (#1062) * bump solc to 0.8.16 (#1065) * Updating dependencies & dedup dev packages (#1064) * fix build (#1067) * [ETHEREUM-CONTRACTS] 1.4.0 Release (#1070) * [JS-SDK] 再见 JS-SDK (#1072) * Don't wrap SubgraphClient's errors with SFError (#1075) * [SDK-CORE] 0.5.6 Patch Fix (#1074) * Get Nix Pilled (#1073) * [SDK-CORE] 0.5.6 Patch Fix (#1074) * The Great TypeScript Refactor (#1069) * Bump terser in /packages/sdk-redux-examples/sdk-redux-react-typecript (#1078) * [ETHEREUM-CONTRACTS] _isPatricianPeriod Patch (#1080) * fix tests expect (#1082) * [ETHEREUM-CONTRACTS] backport 1.4.1 fixes (#1084) * [JS-SDK] Half undo deprecation (#1098) * [ETHEREUM-CONTRACTS] CFAv1Forwarder Fixes (#1094) * Fix links to the examples repo (#1100) * [ETHEREUM-CONTRACTS] CFA Hooks (#1099) * Fix subgraph testing: copy upstream docker compose file (#1109) * [ETHEREUM-CONTRACTS] SuperfluidFrameworkDeployer Additions (#1104) * Update of the nix flake tooling (#1108) * [ETHEREUM-CONTRACTS/SDK-CORE/SUBGRAPH] Use more Typechain capabilities (#1113) * [ETHEREUM-CONTRACTS/SDK-CORE] CFAv1 Forwarder Integration (#1118) * [ETHEREUM-CONTRACTS/SDK-CORE] Ethereum-Contracts 1.4.2 / SDK-Core 0.5.7 (#1119) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: elvijsTDL <77115130+elvijsTDL@users.noreply.github.com> Co-authored-by: David A. Divas <62566465+Daldiv@users.noreply.github.com> Co-authored-by: Miao ZhiCheng <miao@superfluid.finance> Co-authored-by: Kaspar Kallas <kaspar@superfluid.finance> Co-authored-by: Joshua Trujillo <Jtriley15@gmail.com> Co-authored-by: Didi <git@d10r.net> Co-authored-by: saflamini <43142465+saflamini@users.noreply.github.com> Co-authored-by: FlacoJones <93455288+FlacoJones@users.noreply.github.com> Co-authored-by: Axe <ngmachado@users.noreply.github.com> Co-authored-by: Jonathan Gustafsson <jonathan@gustafsson.work> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sffn3va <114768934+sffn3va@users.noreply.github.com> Co-authored-by: tokdaniel <7677603+tokdaniel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#994