Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'enabled' flag to tracing config #374

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Add 'enabled' flag to tracing config #374

merged 1 commit into from
Aug 8, 2023

Conversation

benbjohnson
Copy link
Collaborator

@benbjohnson benbjohnson commented Aug 8, 2023

Currently, the trace log is enabled when tracing.path is set. However, it can be useful to selectively choose which node has tracing enabled.

This PR adds a tracing.enabled field which defaults to true. If it is true and the tracing.path is set then the trace log is enabled. This PR was tested manually.

tracing:
  enabled: ${FLY_REGION == 'syd'}
  path:    "/var/log/litefs/trace.log"

@benbjohnson benbjohnson merged commit 2948332 into main Aug 8, 2023
16 checks passed
@benbjohnson benbjohnson deleted the tracing-enabled branch August 8, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant