Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote debugging features #6

Merged
merged 5 commits into from
Sep 20, 2021
Merged

Remote debugging features #6

merged 5 commits into from
Sep 20, 2021

Conversation

Hehk
Copy link

@Hehk Hehk commented Sep 9, 2021

2 logging related things

  • Fixing the cloudwatch link so that it works to open remote logs
  • Adding a way for when running a single test in remote we get back the console logs

2 things around remote timeouts were changed

  • Timeout error is now a bit more obvious
  • now a extendRemoteTimeout will be passed into tests to allow a way to change the timeout for tests that need it

@Hehk Hehk requested a review from zindlerb September 9, 2021 17:48
@Hehk Hehk changed the title Remote logging Remote debugging features Sep 9, 2021
Copy link

@zindlerb zindlerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hehk This looks good overall. What is the process for running this branch against the codebase? I want to qa it a bit

lib/chrome.js Show resolved Hide resolved
Copy link

@zindlerb zindlerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hehk Hehk merged commit 691cecc into master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants