[SuperEditor] Center caret based on width instead of expanding to the…

… right (#1982)
superlistapp · May 6, 2024 · 0a4a56d · 0a4a56d
1 parent 68dada6
commit 0a4a56d
Show file tree

Hide file tree

Showing 18 changed files with 2 additions and 1 deletion.
diff --git a/super_editor/lib/src/default_editor/document_caret_overlay.dart b/super_editor/lib/src/default_editor/document_caret_overlay.dart
@@ -164,7 +164,8 @@ class CaretDocumentOverlayState extends DocumentLayoutLayerState<CaretDocumentOv
       return null;
     }
 
-    Rect caretRect = documentLayout.getEdgeForPosition(documentSelection.extent)!;
+    Rect caretRect =
+        documentLayout.getEdgeForPosition(documentSelection.extent)!.translate(-widget.caretStyle.width / 2, 0.0);
 
     final overlayBox = context.findRenderObject() as RenderBox?;
     if (overlayBox != null && overlayBox.hasSize && caretRect.left + widget.caretStyle.width >= overlayBox.size.width) {

diff --git a/super_editor/test_goldens/editor/goldens/super-editor-image-caret-upstream.png b/super_editor/test_goldens/editor/goldens/super-editor-image-caret-upstream.png
diff --git a/super_editor/test_goldens/editor/goldens/super-editor_selection-color_custom.png b/super_editor/test_goldens/editor/goldens/super-editor_selection-color_custom.png
diff --git a/super_editor/test_goldens/editor/goldens/super-editor_selection-color_default.png b/super_editor/test_goldens/editor/goldens/super-editor_selection-color_default.png
diff --git a/...itor/test_goldens/editor/goldens/text-scaling-paragraph-collapsed-selection.png b/...itor/test_goldens/editor/goldens/text-scaling-paragraph-collapsed-selection.png
diff --git a/...ditor/test_goldens/editor/goldens/text-scaling-paragraph-expanded-selection.png b/...ditor/test_goldens/editor/goldens/text-scaling-paragraph-expanded-selection.png
diff --git a/...ns/super-editor_text-entry_composing-region-showing-nothing_paragraph_linux.png b/...ns/super-editor_text-entry_composing-region-showing-nothing_paragraph_linux.png
diff --git a/.../super-editor_text-entry_composing-region-showing-nothing_paragraph_windows.png b/.../super-editor_text-entry_composing-region-showing-nothing_paragraph_windows.png
diff --git a/...dens/super-editor_text-entry_composing-region-shows-nothing_list-item_linux.png b/...dens/super-editor_text-entry_composing-region-shows-nothing_list-item_linux.png
diff --git a/...ns/super-editor_text-entry_composing-region-shows-nothing_list-item_windows.png b/...ns/super-editor_text-entry_composing-region-shows-nothing_list-item_windows.png
diff --git a/...y/goldens/super-editor_text-entry_composing-region-shows-nothing_task_linux.png b/...y/goldens/super-editor_text-entry_composing-region-shows-nothing_task_linux.png
diff --git a/...goldens/super-editor_text-entry_composing-region-shows-nothing_task_windows.png b/...goldens/super-editor_text-entry_composing-region-shows-nothing_task_windows.png
diff --git a/.../super-editor_text-entry_composing-region-shows-underline_list-item_macOS_1.png b/.../super-editor_text-entry_composing-region-shows-underline_list-item_macOS_1.png
diff --git a/.../super-editor_text-entry_composing-region-shows-underline_list-item_macOS_2.png b/.../super-editor_text-entry_composing-region-shows-underline_list-item_macOS_2.png
diff --git a/.../super-editor_text-entry_composing-region-shows-underline_paragraph_macOS_1.png b/.../super-editor_text-entry_composing-region-shows-underline_paragraph_macOS_1.png
diff --git a/.../super-editor_text-entry_composing-region-shows-underline_paragraph_macOS_2.png b/.../super-editor_text-entry_composing-region-shows-underline_paragraph_macOS_2.png
diff --git a/...ldens/super-editor_text-entry_composing-region-shows-underline_task_macOS_1.png b/...ldens/super-editor_text-entry_composing-region-shows-underline_task_macOS_1.png
diff --git a/...ldens/super-editor_text-entry_composing-region-shows-underline_task_macOS_2.png b/...ldens/super-editor_text-entry_composing-region-shows-underline_task_macOS_2.png