Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SuperEditor] Carat, selection handles, and overlays should hide behind above-keyboard toolbars #893

Closed
Jethro87 opened this issue Dec 14, 2022 · 3 comments · Fixed by #1524
Closed

[SuperEditor] Carat, selection handles, and overlays should hide behind above-keyboard toolbars #893

Jethro87 opened this issue Dec 14, 2022 · 3 comments · Fixed by #1524
Assignees
@matthew-carroll
Labels
f:clearful Funded by Clearful

Comments

@Jethro87
Copy link
Contributor

They are also visible above the "panel_behind_keyboard" in #876.

RPReplay_Final1671050439.mov
@matthew-carroll matthew-carroll added the f:clearful Funded by Clearful label Jan 21, 2023
angelosilvestre added a commit to angelosilvestre/super_editor that referenced this issue Jan 24, 2023
@angelosilvestre
[SuperEditor] Add Overlay to super_editor widget tree (Resolves super…
db081b0 
…listapp#893)
@angelosilvestre
Copy link
Collaborator

Currently, for Android and iOS we display the caret and the drag handles in an OverlayEntry. We will need to replace the mobile interactor with the layer system, which is already used on desktop.

@angelosilvestre angelosilvestre mentioned this issue Jan 25, 2023
Closed
@Jethro87
Copy link
Contributor Author

@matthew-carroll Now that #1256 has merged, is it possible to show the carat, selection handles, and overlays below a mobile keyboard toolbar?

@matthew-carroll
Copy link
Contributor

@Jethro87 we should have at least a couple options. I mentioned those in this ticket: #398

I think the primary question is whether we want app-level overlays, document overlays, or both.

@matthew-carroll matthew-carroll mentioned this issue Sep 26, 2023
Merged
matthew-carroll added a commit that referenced this issue Oct 16, 2023
@matthew-carroll
WIP: put mounted keyboard toolbar above drag handles (Resolves #893)
0481186
This was referenced Oct 16, 2023
Merged
Closed
matthew-carroll added a commit that referenced this issue Oct 17, 2023
@matthew-carroll
Mobile mounted toolbar now appears above Android overlay controls, mi…
185cce5 
…grated mounted toolbar and Android controls to OverlayPortal (Resolves #893)(Resolves #1510) (#1524)
github-actions bot pushed a commit that referenced this issue Oct 17, 2023
@matthew-carroll @web-flow
Mobile mounted toolbar now appears above Android overlay controls, mi…
8d64347 
…grated mounted toolbar and Android controls to OverlayPortal (Resolves #893)(Resolves #1510) (#1524)
matthew-carroll added a commit that referenced this issue Oct 17, 2023
@matthew-carroll
Mobile mounted toolbar now appears above Android overlay controls, mi…
ce11f26 
…grated mounted toolbar and Android controls to OverlayPortal (Resolves #893)(Resolves #1510) (#1524)
matthew-carroll added a commit that referenced this issue Oct 23, 2023
@matthew-carroll
Update SuperEditor and SuperReader layer system to provide app-level …
b2abadb 
…composition (iOS)(Relates to #424, #893, #1166)(Resolves #1508) (#1470)
github-actions bot pushed a commit that referenced this issue Oct 23, 2023
@matthew-carroll @web-flow
Update SuperEditor and SuperReader layer system to provide app-level …
ef09ab4 
…composition (iOS)(Relates to #424, #893, #1166)(Resolves #1508) (#1470)
@matthew-carroll matthew-carroll mentioned this issue Oct 23, 2023
Merged
matthew-carroll added a commit that referenced this issue Oct 23, 2023
@matthew-carroll
Update SuperEditor and SuperReader layer system to provide app-level …
68d75db 
…composition (iOS)(Relates to #424, #893, #1166)(Resolves #1508) (#1470)
dxvid-pts pushed a commit to dxvid-pts/super_editor that referenced this issue Feb 11, 2024
@matthew-carroll @dxvid-pts
Update SuperEditor and SuperReader layer system to provide app-level …
53e2e98 
…composition (iOS)(Relates to superlistapp#424, superlistapp#893, superlistapp#1166)(Resolves superlistapp#1508) (superlistapp#1470)
@BazinC BazinC mentioned this issue Jun 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthew-carroll matthew-carroll

Labels
f:clearful Funded by Clearful
Projects
None yet
Milestone
No milestone
3 participants
@Jethro87 @matthew-carroll @angelosilvestre