[SuperEditor] Fix content jumping when typing close to the editor's edge (Resolves #720) #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperEditor] Fix content jumping when typing close to the editor's edge. Resolves #720
Typing at the first two lines of the editor was causing the content to jump, as seen in this video:
Screen.Recording.2022-07-30.at.22.02.09.mov
This is caused by the
DragHandleAutoScroller, which updates thescrollPositionevery time we are closer to the edge than what's defined by its_dragAutoScrollBoundary. The issue is more evident if we use a custom stylesheet with less padding because we will be closer to the edge.The issue is also happening when typing at the last line of the document.
This PR changes the behavior to avoid updating the
scrollPositionif we are already at the edge of the editor.