Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpredictable behavior in automatic bridges #234

Closed
liftbag opened this issue May 11, 2020 · 2 comments
Closed

Unpredictable behavior in automatic bridges #234

liftbag opened this issue May 11, 2020 · 2 comments
Labels
enhancement fix is live in the last release Please download /build the last release and try to reproduce.

Comments

@liftbag
Copy link

liftbag commented May 11, 2020

Version

2.2.50 (also in PrusaSlicer 2.2.0)

Operating system type + version

macOS Catalina 10.15.4

Behavior

  • Sorry to report it here, as this is an error imported from PrusaSlicer. If you deem it appropriate, I also report it in PrusaSlicer.
    Automatically generated bridges have two types of inaccuracies, which depends on the angle of the part.

This is an object created to evaluate the automatic generation of bridges. As can be seen, the most accurate bridge is the one below. The rest show parallelism defects with the general trend of the perimeters, and a detachment from the perimeters, due to the starting point.

Schermata 2020-05-11 alle 12 40 13

The strategies adopted vary according to the rotation angle of the object: in this case, all bridges do not run parallel to the perimeters

Schermata 2020-05-11 alle 12 41 21

This is how it would be correct to make a bridge

Schermata 2020-05-11 alle 12 42 07

Here we see the lack of parallelism between the bridges and the perimeters

Schermata 2020-05-11 alle 12 42 29

This is probably difficult to solve, as the starting point of the bridge filling is determined by the general slicing algorithm.

Schermata 2020-05-11 alle 12 59 50

Simplify3D also suffers from the detachment of the bridges from the perimeters, but the angle is correct instead.

Schermata 2020-05-11 alle 13 29 30

Project File (.3MF) where problem occurs

bridge_angle_test_five_arms.3mf.zip

@supermerill
Copy link
Owner

supermerill commented May 11, 2020

yes, it's not optimal and a bit difficult to improve.

It doesn't known where the periemters are. It has an area to fill and an area where it can anchor the bridge. With that, it tries many angle and keep the one where there are the "most area filled" with anchor. Maybe that's why sometimes it's not strait, to try to fill more area... have to add some test cases.
Problem with the gap, is that if it doesn't go just at the right width, the current algorithm isn't smart enough to left a gap in the middle and fill it with a little bridge/gapfill.

It's a big project to rewrite it.

@liftbag
Copy link
Author

liftbag commented May 11, 2020

It's a big project to rewrite it.

I actually imagined it.

@supermerill supermerill added this to starting blocks in Big cool features Oct 1, 2020
@supermerill supermerill added the fixed for the next version That means that you should be able to test it in the latest nightly build label Oct 28, 2021
@supermerill supermerill removed this from starting blocks in Big cool features Oct 28, 2021
supermerill added a commit that referenced this issue Oct 28, 2021
  (currently 70% coverage, 15% median length, 15% max length, 5% bonus for following a perimeter)
Fix: Now consider bridge as full fill whatever the bridge_overlap is
#565
#234
#149
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement fix is live in the last release Please download /build the last release and try to reproduce.
Projects
None yet
Development

No branches or pull requests

2 participants