Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge auto angle: FAIL #565

Closed
Zulaner opened this issue Oct 13, 2020 · 5 comments
Closed

Bridge auto angle: FAIL #565

Zulaner opened this issue Oct 13, 2020 · 5 comments
Labels
duplicate This issue or pull request already exists enhancement fixed for the next version That means that you should be able to test it in the latest nightly build

Comments

@Zulaner
Copy link

Zulaner commented Oct 13, 2020

Version

2.2.54 (night build)

Operating system type + version

Windows

Behavior

the automatic angles are wrong

Project File (.3MF) where problem occurs

Bridging_Test.zip.amf.zip
@Zulaner
Copy link
Author

Zulaner commented Oct 13, 2020

image

@neophyl
Copy link

neophyl commented Oct 13, 2020

Actually the one on the right would be my preferred printing angle for the bridge as it’s the shortest distance. The ok one looks very long so that will droop a lot.

@Zulaner
Copy link
Author

Zulaner commented Oct 13, 2020

the perimeters being detected as overhang, these should not be considered for calculating the bridge distance

@supermerill
Copy link
Owner

supermerill commented Oct 13, 2020 •
edited

Currently, the brute-force algorithm check every 2° angle, so it's easy to not be optimal if the optimal angle isn't a multiple of 2.

also duplicate of #234 #149

It's something to revamp... But it will takes time.
Maybe i could publish the hidden setting in the meantime?

@girrrrrrr2
Copy link

Maybe i could publish the hidden setting in the meantime?

That would probably an easy temporary fix. Maybe have a screen somewhere that has a bunch of settings like this, with the request to reach out if you find a good parameter, or something.

@supermerill supermerill added duplicate This issue or pull request already exists enhancement labels Oct 15, 2020
@supermerill supermerill added the fixed for the next version That means that you should be able to test it in the latest nightly build label Oct 28, 2021
supermerill added a commit that referenced this issue Oct 28, 2021
@supermerill
Better bridge angle computation, and ready for tweaking weights
6832dab 
  (currently 70% coverage, 15% median length, 15% max length, 5% bonus for following a perimeter)
Fix: Now consider bridge as full fill whatever the bridge_overlap is
#565
#234
#149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists enhancement fixed for the next version That means that you should be able to test it in the latest nightly build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@supermerill @Zulaner @neophyl @girrrrrrr2