Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SetSizeHints from dialog creation #970

Closed
wants to merge 48 commits into from

Conversation

Limb
Copy link

@Limb Limb commented Feb 21, 2021

Calling SetSizeHints is discouraged in wxDialogs per https://docs.wxwidgets.org/trunk/classwx_window.html#a307329dc3b10f5584aeb2cbce9293ffd

With this call enabled, the html window was not being accounted for when the window was resized during creation.

Fixes #933

rackley096794 and others added 30 commits November 3, 2020 13:18
Fixing up Visual Studio 2019 build steps as they were missing a few steps that caused issues during building.  Ref: prusa3d#3743.  Also moved the current step-by-step instructions to the top of the page and left the older/outdated instructions for reference purposes at the bottom as they still contain some useful details.
…MM-printer profile and extruder colors is set to the filament colors

+ Fixed a bug with updating colors in extruder editors in ObjectList, when we use filaments colors for extruders and some filament profile is switched
Updating the Russian translation PrusaSlicer-2.3.0-rc3 by Andylg
Fixed parsing of Point3, fortunately Point3 was used at just a single
command line parameter, thus this was not a big deal.
with an updated Xcode / clang incorrectly reporting that it supports
__cpp_lib_uncaught_exceptions while it does not if targeting older
platforms. This issue has been fixed in boost 1.74.0 and 1.75.0
…rusa3d#5813)

Don't use
if (ptr)
	delete ptr;
call
delete ptr;
directly, it contains the test for null ptr.
Importing a config bundle as a config file was broken for
multi material FDM printers, where a different filament was active
for each extruder.
…y is provided.

This was broken between 2.2.0 and 2.3.0 (1bffc2b) and changed the CLI behaviour.
Also related to 5029.
tamasmeszaros and others added 18 commits January 19, 2021 15:01
(deriving the printer technology from the merged configs).
Set the printer_technology field.
an update of wxWidgets, which do not compile cleanly on 10.9 without
further patching.
fixing "percent first layer speed was not applied over autospeed." GH upstream Slic3r prusa3d#2945
our GH issue First Layer Speed Percentage not applying (prusa3d#5829)
where we have issues with false positives of address sanitizer
https://github.com/google/sanitizers/wiki/AddressSanitizerContainerOverflow#false-positives
Setting ASAN_OPTIONS=detect_container_overflow=0 inside Info.plist
Fixed extrusion width validation logic in case the extrusion width
was specified wrt. layer height.
…ed on Manipulation panel for coordinate space choice now.

+ Fix of warning on wxBitmap.SetWidth(): deleted meaningless from wxWidgets 3.0 code
(wxWidgets 3.1.4 can binding of wxEVT_DPI_CHANGED now, so it was called msw_rescale() for most of the controls redundantly)

+ Fixed update of the DoubleSlider after changing of the system color
Calling SetSizeHints is discouraged in wxDialogs per https://docs.wxwidgets.org/trunk/classwx_window.html#a307329dc3b10f5584aeb2cbce9293ffd

With this call enabled, the html window was not being accounted for when the window was resized during creation.

Fixes supermerill#933
@supermerill
Copy link
Owner

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build from Source on Ubuntu - no text for calibration
8 participants