Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134
From matrix conversation:
The problem was exactly here: https://github.com/superseriousbusiness/gotosocial/blob/main/internal/text/common.go#L62
Instead of returning
in
if no matching tags are found, it should returnmatch
.So basically what happened in that function was that the hashtagfinderregex matched
#Hashtag
in the string, then it started iterating through the list of tags looking for the replacement... HOWEVER,tag.Name
was automatically lowercased by some of the text parsing functionality from earlierwhich means that
strings.TrimSpace(match) == fmt.Sprintf("#%s", tag.Name)
was not trueso the fallback behavior was to return in, which is the whole status
so #Hashtag was being replaced by ALL of in
so the two fixes are to:
strings.EqualFold
instead of==