Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Silence maxprocs logging #1402

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

daenney
Copy link
Member

@daenney daenney commented Jan 30, 2023

Description

This switches the logger to Debug. By default the library logs things internally despite returning errors. Due to the way we had it hooked up this resulted in scary error level logs being emitted for innocuous errors. Now those errors will only be visible in debug mode.

Fixes: #1398
Relates to: #1336

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

This switches the logger to Debug. By default the library logs things
internally despite returning errors. Due to the way we had it hooked up
this resulted in scary error level logs being emitted for innocuous
errors. Now those errors will only be visible in debug mode.

Fixes: superseriousbusiness#1398
Relates to: superseriousbusiness#1336
@daenney
Copy link
Member Author

daenney commented Jan 30, 2023

I went for Debug so we can still get the logs it emits just in case. I'm happy to mute it entirely with a no-op logger too.

@tsmethurst
Copy link
Contributor

That looks good to me :)

@tsmethurst tsmethurst merged commit eccb380 into superseriousbusiness:main Jan 31, 2023
@daenney daenney deleted the fixup-1336 branch March 12, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Setting maxprocs may log a scary but innocuous error
2 participants