Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] always go through status parent dereferencing on isNew, even on data-race #2402

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

As the title says really. This isn't ideal, but it's the only (easy) way of handling this right now, without performing a parent dereference within mutex lock and possibly risk lock-ups if there's any threads that end up self-referencing. This shouldn't happen too often so performance impact shouldn't be much, especially as all of those statuses will also just return fetched_at as too new (all of which will be cache hits).

Also removes the dereference account step after dereferencing status in the fedi API worker, as to reach that point the account must already have been dereferenced / refreshed.

Closes #2396

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor

Nice one!

@tsmethurst tsmethurst merged commit 5fd2e42 into superseriousbusiness:main Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Parent status not always being dereferenced when a reply comes in
2 participants