[bugfix] always go through status parent dereferencing on isNew, even on data-race #2402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title says really. This isn't ideal, but it's the only (easy) way of handling this right now, without performing a parent dereference within mutex lock and possibly risk lock-ups if there's any threads that end up self-referencing. This shouldn't happen too often so performance impact shouldn't be much, especially as all of those statuses will also just return fetched_at as too new (all of which will be cache hits).
Also removes the dereference account step after dereferencing status in the fedi API worker, as to reach that point the account must already have been dereferenced / refreshed.
Closes #2396
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.