Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Run ANALYZE for SQLite after latest migrations #2427

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

tsmethurst
Copy link
Contributor

See #2425 for more details.

We may want to run VACUUM as well, but since this can take quite a long time (10-15 minutes-ish), it might be better not to, but instead tell folks to run it manually. I'm not entirely sure yet.

@daenney
Copy link
Member

daenney commented Dec 8, 2023

I'm wondering if instead of doing this as a migration itself, we can see if migrations happened during startup and then trigger an analyze? That way we don't have to remember to do this after each migration.

@daenney
Copy link
Member

daenney commented Dec 8, 2023

But for the case of the 0.13 cycle I think this is fine. We can just merge this.

@tsmethurst
Copy link
Contributor Author

Ack, yeah that makes sense. Let's do it properly (and perhaps include autovacuum as well) once 0.13.0 is out.

@tsmethurst tsmethurst merged commit 4779aec into main Dec 8, 2023
3 checks passed
@tsmethurst tsmethurst deleted the sqlite_analyze branch December 8, 2023 15:59
@daenney
Copy link
Member

daenney commented Dec 8, 2023

We can hook it here I think:

if err != nil && !strings.Contains(err.Error(), "no migrations") {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants