Make it easier to add kart specific engine sound effects

[hiker]

At the moment engine sound effect filename are hardcoded in kart properties (lines 559). Fix this so that karts can specific other engine sounds (without any more code changes).

[konstin]

I think I'll work on that in the next week. My Idea is to add a new node to karts.xml maybe called "enginge-sound" or something like that where a sound file can be specified. If a kart doesn't have the new node, the old way will be used.

[hiker]

Check out what's already there ;) This is a pretty trivial ticket (depending on how you approach this). Note that changes to the kart.xml file should be avoided, since it would mean we have to re-export all karts.

[konstin]

I wrote fix for this Issue, but I think I have to open a new issue about implementing special sounds for each kart, because at the moment, there're only lots of todo's and many lines of unfinished code, although there are ready-to-use .ogg's (e.g. for Tux). So here's what I did:

        if      (s == "large") m_engine_sfx_type = "engine_large";
        else if (s == "small") m_engine_sfx_type = "engine_small";
        else
        {
            if (sfx_manager->soundExist(s))
            {
                m_engine_sfx_type = s;
            }
            else 
            {
                Log::error("[KartProperties]",
                           "Kart '%s' has an invalid engine '%s'.",
                           m_name.c_str(), s.c_str());
                m_engine_sfx_type = "engine_small";
            }
        }

This could done better by changing either small and large in the kart.xml-files or renaming engine large and engine small, but both possibilities aren't very good.

[hiker]

Hmm - the comments/to-do's about kart-specific sounds are most likely to give each character a different sfx when it is hit, or fires something or so. So that would be unrelated to the engine sfx (and it did actually work last time I tried, but we never had enough convincing sfx to use it ... and hearing the same sfx all the time got quickly pretty annoying).

Ideally we would also cover sound effects to be packaged with addon karts, but that's then a lot of additional work, and there's no need for this at this stage.

Could you just issue a pull request for this?

[hiker]

I reopen this ticket since indeed we should support sound effects as part of addon karts, not only pre-defined sounds in STK.

[hiker]

See also #278, which has some example voices.

[konstin]

There are three 6s mp3, so I'ld rather close it in favor of a general audio discussion (possibly after the release)